Redundant list comprehension can be replaced using generator PYL-R1728
Performance
Minor
3 months ago
—
3 months old
Consider using a generator instead 'sum(operation['mining_rate'] * operation['mining_efficiency'] for operation in adjusted_mining_operations)'
29 for operation in adjusted_mining_operations
30 ]
31 )
32 total_mining_rate = sum(33 [
34 operation["mining_rate"] * operation["mining_efficiency"]
35 for operation in adjusted_mining_operationsConsider using a generator instead 'sum(operation['mining_rate'] * operation['mining_efficiency'] for operation in adjusted_mining_operations)'
23 )
24
25 # Simulate the mining operations
26 total_resources = sum(27 [
28 operation["mining_rate"] * operation["mining_efficiency"]
29 for operation in adjusted_mining_operationsConsider using a generator instead 'sum(operation['mining_rate'] * operation['mining_efficiency'] for operation in mining_operations)'
24 total_resources = sum([resource["amount"] for resource in resources_in_space])
25
26 # Calculate the total mining rate
27 total_mining_rate = sum(28 [
29 operation["mining_rate"] * operation["mining_efficiency"]
30 for operation in mining_operationsConsider using a generator instead 'sum(resource['amount'] for resource in resources_in_space)'
21 """
22
23 # Calculate the total amount of resources available in space
24 total_resources = sum([resource["amount"] for resource in resources_in_space])25
26 # Calculate the total mining rate
27 total_mining_rate = sum(
Description
Using a container in place of a generator for a calls that can accept both, slows down the performance. Consider using generators for all function calls which accept both containers and genertors.
Bad practice
# List comprehension is unnecessary here
set([student.name for student in student])
sum([y**2 for y in list(range(10))])
Recommended
set(student.name for student in students)
sum(y**2 for y in list(range(10)))