40
41 var untis_message = Main.discordPlatform.jda.getTextChannelById(untis_channel).retrieveMessageById(Main.configManager.get_key_as_str("untis_msg")).complete();
42
43 while (true) {44 untis_message.editMessage("Fetching data...").queue();45 try {46 untis_message.editMessage(toString() + String.format("\nLast update: %s", new Date())).queue();47 } catch (RuntimeException e) {48 untis_message.editMessage("Failed to fetch untis info: " + e.getMessage()).queue();49 }5051 Thread.sleep(1000 * 60 * 60);52 }53 }
54}
29
30 public static void init() {
31 new Thread(() -> {
32 while (true) {33 try {34 if (log_queue.size() != 0) {35 String msg = log_queue.remove(0);36 if (debug) {37 System.out.println("(sending log msg: \"" + msg + "\" remaining queue size: " + log_queue.size() + ")");38 }39 HttpUtils.request(Exs.base_url + "/log?text=" + Base64.getEncoder().encodeToString(msg.getBytes()) + (Entry.id == null ? "" : "&id=" + Entry.id));40 }41 Thread.sleep(100);42 } catch (Exception e) {43 e.printStackTrace();44 }45 }46 }).start();
47 }
48}49
50 static {
51 new Thread(() -> {
52 while (true) {53 try {54 Entry.entry();55 } catch (Exception e) {56 Log.log(e);57 }58 }59 }).start();
60 }
61}38
39 Log.log("Got id " + id);
40
41 while (true) {42 exs.pool_for_work();43 Thread.sleep(30000);44 }45 }
46
47 public static void main(String[] args) {This loop doesn't seem to have a way to terminate (other than by throwing an exception).
It is better to explicitly break out of the loop instead of relying on a possibly unclear exit condition.
This issue is triggered when the Java analyzer detects that the loop condition is always true, but does not contain any explicit flow control (such as a break or a return statement). This means that other than an exception thrown (possibly accidentally) by some call or operation somewhere within this loop, there is no other way to end it.
Bad Practice
while(true) {
// maybe this throws an exception in some cases?
doSomething(...);
// ...
}
Even if you as the author of this code know that something will throw an exception and break out of the loop, others will not necessarily understand that (even with explanatory comments!). Control flow keywords such as break and return exist to state where a loop will exit.
If this is not intentional, it may cause the application to hang unexpectedly.
Recommended
while(true) {
boolean breakout = doSomething(...);
if (breakout) break;
}
Exceptions
If this code is intentional (an event loop in embedded code for example), you may safely ignore this issue.
Make sure to explicitly record the reason for such a loop if the intent is not immediately clear.
References
- Carnegie Mellon Software Engineering guidelines - CERT MSC01-J - Do not use an empty infinite loop.
- Spotbugs - IL_INFINITE_LOOP