Method can be declared static JAVA-W1057
Anti-pattern
Major
2 months ago
—
6 months old
This method can be static
237 PvPlayer.shutdownExecutorAndWait();
238 }
239
240 private final void removeTeams() {241 final Scoreboard scoreboard = Bukkit.getScoreboardManager().getMainScoreboard();242 final Team pvpon = scoreboard.getTeam("PvPOn");243 if (pvpon != null) {244 pvpon.unregister();245 }246 final Team pvpoff = scoreboard.getTeam("PvPOff");247 if (pvpoff != null) {248 pvpoff.unregister();249 }250 }251
252 // TODO replace untag and tag with gettagtask
253 public final void untag(final PvPlayer p) {
Description
Private final methods that do not access instance fields should be declared static.
Since the method is private and final, it can't possibly be overridden. Therefore, the only possible definition of the method that exists doesn't access any instance fields. So we can safely declare it as static.
Bad Practice
public class Klass {
private final int aField = 10;
private final void method() {
// ...statements that do not access `aField`
}
}
Recommended
Consider declaring the method static.
public class Klass {
private final int aField = 10;
private static final void method() {
// ...statements that do not access `aField`
}
}
References
- StackOverflow - Should all methods that do not use instance fields be static?