JS-0007 @ c8ce63f • CIDARLAB / 3DuF

Run summary

2 years ago

2240cb1..c8ce63f

50 s

Found duplicate keys in object literals JS-0007

Bug risk

Major

9 occurrences in this check

Duplicate key 'rotation'.

src/app/library/gradientGenerator.js

 77            out: 90,
 78            spacing: 90000,
 79            height: 1200,
 80            rotation: 360 81        };
 82
 83        this.__featureParams = {

Duplicate key 'rotation'.

src/app/library/gradientGenerator.js

 63            out: 3,
 64            spacing: 10,
 65            height: 10,
 66            rotation: 0, 67        };
 68
 69        this.__maximum = {

Duplicate key 'rotation'.

src/app/library/gradientGenerator.js

 36            out: 3,
 37            spacing: 10000,
 38            height: 250,
 39            rotation: 0 40        };
 41
 42        this.__units = {

Duplicate key 'rotation'.

src/app/library/curvedMixer.js

 19            numberOfBends: "Float",
 20            channelWidth: "Float",
 21            bendLength: "Float",
 22            rotation: "Float", 23            height: "Float"
 24        };
 25

Duplicate key 'rotation'.

src/app/library/curvedMixer.js

 29            channelWidth: 0.8 * 1000,
 30            bendSpacing: 1.23 * 1000,
 31            numberOfBends: 1,
 32            rotation: 0, 33            bendLength: 2.46 * 1000,
 34            height: 250
 35        };

Duplicate key 'rotation'.

src/app/library/curvedMixer.js

 50            channelWidth: 10,
 51            bendSpacing: 10,
 52            numberOfBends: 1,
 53            rotation: 0, 54            bendLength: 10,
 55            height: 10
 56        };

Duplicate key 'rotation'.

src/app/library/curvedMixer.js

 61            channelWidth: 2000,
 62            bendSpacing: 6000,
 63            numberOfBends: 20,
 64            rotation: 360, 65            bendLength: 12 * 1000,
 66            height: 1200
 67        };

Duplicate key 'height'.

src/app/library/chemostatring.js

  48            radius: "&mu;m",
  49            rotation: "&deg;",
  50            volume: "&mu;m3",
  51            height: "&mu;m"  52        };
  53
  54        this.__minimum = {

Duplicate key 'rotation'.

src/app/library/chemostatring.js

  46            controlChannelWidth: "&mu;m",
  47            chemostatChannelWidth: "&mu;m",
  48            radius: "&mu;m",
  49            rotation: "&deg;",  50            volume: "&mu;m3",
  51            height: "&mu;m"
  52        };

Description

Multiple properties with the same key in object literals should be avoided.

When an object literal has multiple properties with the same key, only the key-value pair that appears last in the source code is considered. This renders all the previous property initializations with the same key useless.

Bad Practice

const obj = {
    city: "nyc",
    city: "ohio"
};
console.log(obj.city); // ohio

const obj = {
    [0x1]: "nyc",
    [1]: "ohio"
};
console.log(obj[1]); // ohio

CIDARLAB / 3DuF

Bad Practice

Recommended