'dnd' is assigned a value but never used
1059 * @memberof ViewManager
1060 */
1061 setupDragAndDropLoad(selector) {
1062 let dnd = new HTMLUtils.DnDFileController(selector, function(files) {1063 let f = files[0];
1064
1065 let reader = new FileReader();
'e' is defined but never used
1063 let f = files[0];
1064
1065 let reader = new FileReader();
1066 reader.onloadend = function(e) {1067 let result = this.result;
1068 try {
1069 result = JSON.parse(result);
'Selection' is defined but never used
40import ExportPanel from "./ui/exportPanel";
41import HelpDialog from "./ui/helpDialog";
42import PaperView from "./paperView";
43import Selection from "./selection"; 44import AdaptiveGrid from "./grid/adaptiveGrid";
45import TaguchiDesigner from "./ui/taguchiDesigner";
46import RightClickMenu from "./ui/rightClickMenu";
'Feature' is defined but never used
47import IntroDialog from "./ui/introDialog";
48import DAFDPlugin from "../plugin/dafdPlugin";
49import { Examples } from "../index";
50import Feature from "../core/feature"; 51import Layer from "../core/layer";
52import Component from "../core/component";
53import DAMPFabricationDialog from "./ui/dampFabricationDialog";
'Layer' is defined but never used
48import DAFDPlugin from "../plugin/dafdPlugin";
49import { Examples } from "../index";
50import Feature from "../core/feature";
51import Layer from "../core/layer"; 52import Component from "../core/component";
53import DAMPFabricationDialog from "./ui/dampFabricationDialog";
54
'Component' is defined but never used
49import { Examples } from "../index";
50import Feature from "../core/feature";
51import Layer from "../core/layer";
52import Component from "../core/component"; 53import DAMPFabricationDialog from "./ui/dampFabricationDialog";
54
55/**
'refresh' is assigned a value but never used
184 * @returns {void}
185 * @private
186 */
187 __addAllDeviceLayers(device, refresh = true) { 188 for (let i = 0; i < device.layers.length; i++) {
189 let layer = device.layers[i];
190 this.addLayer(layer, i, false);
'refresh' is assigned a value but never used
197 * @memberof ViewManager
198 * @returns {void}
199 */
200 __removeAllDeviceLayers(device, refresh = true) { 201 for (let i = 0; i < device.layers.length; i++) {
202 let layer = device.layers[i];
203 this.removeLayer(layer, i, false);
'refresh' is assigned a value but never used
682 * @returns {void}
683 * @memberof ViewManager
684 */
685 refresh(refresh = true) { 686 this.updateQueue.run();
687 //Update the toolbar
688 let spacing = Registry.currentGrid.getSpacing();
'zoom_min' is defined but never used
7 this.__setupZoomSlider(zoom_min, zoom_max);
8 }
9
10 __setupZoomSlider(zoom_min, zoom_max) {11 if (this.__zoomSlider == null) {
12 throw new Error("Could not find HTML element for the grid resolution slider");
13 }
'zoom_max' is defined but never used
7 this.__setupZoomSlider(zoom_min, zoom_max);
8 }
9
10 __setupZoomSlider(zoom_min, zoom_max) {11 if (this.__zoomSlider == null) {
12 throw new Error("Could not find HTML element for the grid resolution slider");
13 }
'handle' is defined but never used
30 //Create the onupdate method
31 let registryref = Registry;
32 let ref = this;
33 this.__zoomSlider.noUiSlider.on("update", function(values, handle, unencoded, tap, positions) {34 if (ref.__isUserGeneratedEvent) {
35 console.log("Zoom Value:", values[0]);
36 //TODO - Map this directly to the zoom functions
'unencoded' is defined but never used
30 //Create the onupdate method
31 let registryref = Registry;
32 let ref = this;
33 this.__zoomSlider.noUiSlider.on("update", function(values, handle, unencoded, tap, positions) {34 if (ref.__isUserGeneratedEvent) {
35 console.log("Zoom Value:", values[0]);
36 //TODO - Map this directly to the zoom functions
'tap' is defined but never used
30 //Create the onupdate method
31 let registryref = Registry;
32 let ref = this;
33 this.__zoomSlider.noUiSlider.on("update", function(values, handle, unencoded, tap, positions) {34 if (ref.__isUserGeneratedEvent) {
35 console.log("Zoom Value:", values[0]);
36 //TODO - Map this directly to the zoom functions
'positions' is defined but never used
30 //Create the onupdate method
31 let registryref = Registry;
32 let ref = this;
33 this.__zoomSlider.noUiSlider.on("update", function(values, handle, unencoded, tap, positions) {34 if (ref.__isUserGeneratedEvent) {
35 console.log("Zoom Value:", values[0]);
36 //TODO - Map this directly to the zoom functions
'e' is defined but never used
41 this.__handsonTableObject = null;
42
43 let reader = new FileReader();
44 reader.onload = function(e) { 45 //console.log(reader.result);
46 ref.loadCSVData(reader.result);
47 };
'ev' is defined but never used
34
35 this.__generateDesignsButton = document.getElementById("download-doe-button");
36
37 this.__generateDesignsButton.addEventListener("click", function(el, ev) { 38 ref.generateAndDownloadTaguchiDesigns();
39 });
40
'el' is defined but never used
34
35 this.__generateDesignsButton = document.getElementById("download-doe-button");
36
37 this.__generateDesignsButton.addEventListener("click", function(el, ev) { 38 ref.generateAndDownloadTaguchiDesigns();
39 });
40
'event' is defined but never used
9
10 //Do the click handler here
11 let ref = this;
12 this.__showResolutionToolBarButton.onclick = function(event) {13 // console.log(ref.__resolutionToolBar.classList);
14 ref.__resolutionToolBar.classList.toggle("showtoolbar");
15 ref.__resolutionToolBar.classList.toggle("hidetoolbar");
'event' is defined but never used
31 let ref = this;
32
33 //Event handlers
34 this.__revertToDefaultsButton.addEventListener("click", function(event) { 35 revertToDefaultParams(ref.__featureTable, ref.__typeString, ref.__setString);
36 });
37 this.__deleteButton.addEventListener("click", function(event) {
'event' is defined but never used
34 this.__revertToDefaultsButton.addEventListener("click", function(event) {
35 revertToDefaultParams(ref.__featureTable, ref.__typeString, ref.__setString);
36 });
37 this.__deleteButton.addEventListener("click", function(event) { 38 Registry.viewManager.view.deleteSelectedFeatures();
39 ref.close();
40 });
'event' is defined but never used
75 });
76
77 ///Cancel Rename
78 this.__renameCancelButton.addEventListener("click", function(event) { 79 let nametext = ref.getComponentName();
80 document.getElementById("componentname_textinput").value = nametext;
81 });
'event' is defined but never used
69 });
70
71 //Save Rename
72 this.__renameSaveButton.addEventListener("click", function(event) { 73 let nametext = ref.__renameTextInput.value;
74 ref.setComponentName(nametext);
75 });
'event' is defined but never used
64 ref.__activateMove();
65 });
66
67 this.__generateArrayButton.addEventListener("click", function(event) { 68 ref.__activateGenerateArray();
69 });
70
'event' is defined but never used
60 ref.__renameIsVisible = !ref.__renameIsVisible;
61 });
62
63 this.__moveButton.addEventListener("click", function(event) { 64 ref.__activateMove();
65 });
66
Description
Found variables that are declared but not used anywhere.
NOTE: In browser applications, DeepSource recommends the use of ESModules over regular
text/javascript
scripts. Currently, we don't support variables that are not explicitly exported, and are injected into other scripts by being included in an HTML file
Unused variables are most often the result of incomplete refactoring. They can lead to confusing code and minor performance hitches.
NOTE: If you have intentionally left a variable unused, we suggest you to prefix the variable name with a _
to prevent them from being flagged by DeepSource.
Bad Practice
// Write-only variables are not considered as used.
let y = 10;
y = 5;
// A variable that modifies only itself isn't considered used.
let z = 0;
z = z + 1;
// Unused argument
(function(x) {
return 5;
})();
// Unused recursive functions also raise this issue.
function fact(n) {
if (n < 2) return 1;
return n * fact(n - 1);
}
// When a function definition destructures an array,
// unused entries from the array also cause warnings.
function getY([x, y]) {
return y;
}
Recommended
let x = 10;
alert(x);
((arg1) => {
return arg1;
})();
let myFunc;
myFunc = (n) => {
// this is legal
if (n < 0) myFunc();
};
// this is also considered legal
console.log(declaredLater);
var declaredLater;
// Only the second argument from the descructured array is used.
function getY([, y]) {
return y;
}