Unexpected var, use let or const instead
234 var checkID = featureID + "_" + key + "_checkbox";
235 var spanID = featureID + "_" + key + "_span";
236 var value = Feature.getDefaultsForType(typeString, setString)[key];
237 var checkBox = createCheckbox(value, checkID);238 var spanValue;
239 if (value === "V") spanValue = "V";
240 else spanValue = "H";Unexpected var, use let or const instead
6import * as FeatureSets from "../../featureSets";
7
8var createSlider = function(min, max, step, start, id) {
9 var div = document.createElement("div"); 10 var p = document.createElement("p");
11 p.setAttribute("style", "min-width: 240px");
12 var slider = document.createElement("input");Unexpected var, use let or const instead
233 var title = createSpan(key);
234 var checkID = featureID + "_" + key + "_checkbox";
235 var spanID = featureID + "_" + key + "_span";
236 var value = Feature.getDefaultsForType(typeString, setString)[key];237 var checkBox = createCheckbox(value, checkID);
238 var spanValue;
239 if (value === "V") spanValue = "V";Unexpected var, use let or const instead
9 var div = document.createElement("div");
10 var p = document.createElement("p");
11 p.setAttribute("style", "min-width: 240px");
12 var slider = document.createElement("input"); 13 slider.className = "mdl-slider mdl-js-slider";
14 slider.setAttribute("type", "range");
15 slider.setAttribute("id", id);Unexpected var, use let or const instead
23 return div;
24};
25
26var createButton = function(iconString) { 27 var button = document.createElement("button"); 28 button.className = "mdl-button mdl-js-button mdl-button--icon"; 29 var icon = document.createElement("i"); 30 icon.className = "material-icons"; 31 icon.innerHTML = iconString; 32 button.appendChild(icon); 33 componentHandler.upgradeElement(button, "MaterialButton"); 34 return button; 35}; 36
37var createValueField = function(start, id, unittext = "") {
38 var div = document.createElement("div");Unexpected var, use let or const instead
24};
25
26var createButton = function(iconString) {
27 var button = document.createElement("button"); 28 button.className = "mdl-button mdl-js-button mdl-button--icon";
29 var icon = document.createElement("i");
30 icon.className = "material-icons";Unexpected var, use let or const instead
26var createButton = function(iconString) {
27 var button = document.createElement("button");
28 button.className = "mdl-button mdl-js-button mdl-button--icon";
29 var icon = document.createElement("i"); 30 icon.className = "material-icons";
31 icon.innerHTML = iconString;
32 button.appendChild(icon);Unexpected var, use let or const instead
34 return button;
35};
36
37var createValueField = function(start, id, unittext = "") { 38 var div = document.createElement("div"); 39 var error = document.createElement("span"); 40 var span = document.createElement("span"); 41 span.innerHTML = unittext; 42 span.style.fontSize = "14px"; 43 error.className = "mdl-textfield__error"; 44 error.innerHTML = "Digits only"; 45 div.className = "mdl-textfield mdl-js-textfield"; 46 var field = document.createElement("input"); 47 field.className = "mdl-textfield__input"; 48 field.setAttribute("type", "text"); 49 field.setAttribute("id", id); 50 field.setAttribute("value", start); 51 field.setAttribute("pattern", "[0-9]*"); 52 field.style.paddingTop = "0px"; 53 div.appendChild(field); 54 div.appendChild(span); 55 div.appendChild(error); 56 div.setAttribute("style", "margin-left: auto; margin-right: auto; display: block;width:65px;padding-top:0px;padding-bottom:5px;"); 57 componentHandler.upgradeElement(div, "MaterialTextfield"); 58 return div; 59}; 60
61var createTableElement = function(child) {
62 var td = document.createElement("td");Unexpected var, use let or const instead
35};
36
37var createValueField = function(start, id, unittext = "") {
38 var div = document.createElement("div"); 39 var error = document.createElement("span");
40 var span = document.createElement("span");
41 span.innerHTML = unittext;Unexpected var, use let or const instead
36
37var createValueField = function(start, id, unittext = "") {
38 var div = document.createElement("div");
39 var error = document.createElement("span"); 40 var span = document.createElement("span");
41 span.innerHTML = unittext;
42 span.style.fontSize = "14px";Unexpected var, use let or const instead
37var createValueField = function(start, id, unittext = "") {
38 var div = document.createElement("div");
39 var error = document.createElement("span");
40 var span = document.createElement("span"); 41 span.innerHTML = unittext;
42 span.style.fontSize = "14px";
43 error.className = "mdl-textfield__error";Unexpected var, use let or const instead
43 error.className = "mdl-textfield__error";
44 error.innerHTML = "Digits only";
45 div.className = "mdl-textfield mdl-js-textfield";
46 var field = document.createElement("input"); 47 field.className = "mdl-textfield__input";
48 field.setAttribute("type", "text");
49 field.setAttribute("id", id);Unexpected var, use let or const instead
58 return div;
59};
60
61var createTableElement = function(child) { 62 var td = document.createElement("td"); 63 td.appendChild(child); 64 return td; 65}; 66
67var createCheckbox = function(checked, id) {
68 var div = document.createElement("div");Unexpected var, use let or const instead
59};
60
61var createTableElement = function(child) {
62 var td = document.createElement("td"); 63 td.appendChild(child);
64 return td;
65};Unexpected var, use let or const instead
64 return td;
65};
66
67var createCheckbox = function(checked, id) { 68 var div = document.createElement("div"); 69 var label = document.createElement("label"); 70 label.className = "mdl-checkbox mdl-js-checkbox mdl-js-ripple-effect"; 71 label.setAttribute("for", id); 72 var input = document.createElement("input"); 73 input.setAttribute("type", "checkbox"); 74 input.setAttribute("id", id); 75 if (checked) input.checked = true; 76 input.className = "mdl-checkbox__input"; 77 label.appendChild(input); 78 componentHandler.upgradeElement(label, "MaterialCheckbox"); 79 div.setAttribute("style", "margin-left: auto; margin-right: auto; display: block;width:12px;position:relative;"); 80 div.appendChild(label); 81 return div; 82}; 83
84var createSpan = function(value, id) {
85 var div = document.createElement("div");Unexpected var, use let or const instead
65};
66
67var createCheckbox = function(checked, id) {
68 var div = document.createElement("div"); 69 var label = document.createElement("label");
70 label.className = "mdl-checkbox mdl-js-checkbox mdl-js-ripple-effect";
71 label.setAttribute("for", id);Unexpected var, use let or const instead
66
67var createCheckbox = function(checked, id) {
68 var div = document.createElement("div");
69 var label = document.createElement("label"); 70 label.className = "mdl-checkbox mdl-js-checkbox mdl-js-ripple-effect";
71 label.setAttribute("for", id);
72 var input = document.createElement("input");Unexpected var, use let or const instead
69 var label = document.createElement("label");
70 label.className = "mdl-checkbox mdl-js-checkbox mdl-js-ripple-effect";
71 label.setAttribute("for", id);
72 var input = document.createElement("input"); 73 input.setAttribute("type", "checkbox");
74 input.setAttribute("id", id);
75 if (checked) input.checked = true;Unexpected var, use let or const instead
81 return div;
82};
83
84var createSpan = function(value, id) { 85 var div = document.createElement("div"); 86 var span = document.createElement("span"); 87 span.innerHTML = value; 88 span.setAttribute("id", id); 89 span.setAttribute("style", "font-size: 16px;"); 90 div.setAttribute("style", "margin-left: none; margin-right: auto; display: block;width:24px;"); 91 div.appendChild(span); 92 return div; 93}; 94
95var createTableRow = function(one, two, three) {
96 var tr = document.createElement("tr");Unexpected var, use let or const instead
82};
83
84var createSpan = function(value, id) {
85 var div = document.createElement("div"); 86 var span = document.createElement("span");
87 span.innerHTML = value;
88 span.setAttribute("id", id);Unexpected var, use let or const instead
83
84var createSpan = function(value, id) {
85 var div = document.createElement("div");
86 var span = document.createElement("span"); 87 span.innerHTML = value;
88 span.setAttribute("id", id);
89 span.setAttribute("style", "font-size: 16px;");Unexpected var, use let or const instead
92 return div;
93};
94
95var createTableRow = function(one, two, three) { 96 var tr = document.createElement("tr"); 97 one.style.borderBottom = "none"; 98 tr.appendChild(one); 99 tr.appendChild(two);100 tr.appendChild(three);101 return tr;102};103
104var generateUpdateFunction = function(sourceID, targetID, typeString, setString, paramString) {
105 return function() {Unexpected var, use let or const instead
93};
94
95var createTableRow = function(one, two, three) {
96 var tr = document.createElement("tr"); 97 one.style.borderBottom = "none";
98 tr.appendChild(one);
99 tr.appendChild(two);Unexpected var, use let or const instead
101 return tr;
102};
103
104var generateUpdateFunction = function(sourceID, targetID, typeString, setString, paramString) {105 return function() {106 var source = document.getElementById(sourceID);107 var target = document.getElementById(targetID);108 var param;109 if (!source.value || source.value === "") {110 return;111 }112 try {113 param = new FloatValue(parseFloat(source.value));114 } catch (err) {115 console.log("Invalid Float value.");116 return;117 }118 target.value = String(param.getValue());119 Registry.viewManager.adjustParams(typeString, setString, paramString, param.getValue());120 };121};122/*
123var generateUpdateFunctionString = function(sourceID, targetID, typeString, setString, paramString) {
124 return function() {Unexpected var, use let or const instead
103
104var generateUpdateFunction = function(sourceID, targetID, typeString, setString, paramString) {
105 return function() {
106 var source = document.getElementById(sourceID);107 var target = document.getElementById(targetID);
108 var param;
109 if (!source.value || source.value === "") {
Description
It is recommended to use let or const over var.
This will help prevent re-declaration of variables that are in the global scope when using var.
ES6 allows programmers to create variables with block scope instead of function scope using the let and const keywords.
Block scope is common in many other programming languages and helps programmers avoid mistakes such as this one:
var count = people.length;
var enoughFood = count > sandwiches.length;
if (enoughFood) {
var count = sandwiches.length; // accidentally overriding the count variable
console.log("We have " + count + " sandwiches for everyone. Plenty for all!");
}
// our count variable is no longer accurate
console.log("We have " + count + " people and " + sandwiches.length + " sandwiches!");
Block scoped variables shadow outer declarations instead of writing to them.
NOTE: There are certain edge cases where users might want to consider var. Consider this example:
var lib = lib || { run: () => {} }
Here, lib might be a library that is exposed to an HTML file using a <script> tag.
The var keyword helps avoid re-writing lib if it has already been declared via an injected script that was executed before this one.
Ideally, you should let bundlers worry about cases like this.
But if you want to use var anyway, consider using a skipcq comment, or disabling the issue altogether.
Bad Practice
var x = "y";
var CONFIG = {};
Recommended
let x = "y";
const CONFIG = {};