JS-0356 @ fe59603 • CIDARLAB / 3DuF

Run summary

6 months ago

11da5c0..fe59603

1 min 9 s

Found unused variables in TypeScript code JS-0356

Performance

Major

210 occurrences in this check

'yspan' is defined but never used

src/componentAPI.ts

557      * @param {*} entity
558      * @memberof ComponentAPI
559      */
560     static getBlackBoxDefinition(xspan: number, yspan: number, ports: Array<any>): LibraryEntryDefinition {561        // TODO: Deal with the ports later
562        // Create a fake definition for the blackbox
563

'ports' is defined but never used

src/componentAPI.ts

557      * @param {*} entity
558      * @memberof ComponentAPI
559      */
560     static getBlackBoxDefinition(xspan: number, yspan: number, ports: Array<any>): LibraryEntryDefinition {561        // TODO: Deal with the ports later
562        // Create a fake definition for the blackbox
563

'xspan' is defined but never used

src/componentAPI.ts

557      * @param {*} entity
558      * @memberof ComponentAPI
559      */
560     static getBlackBoxDefinition(xspan: number, yspan: number, ports: Array<any>): LibraryEntryDefinition {561        // TODO: Deal with the ports later
562        // Create a fake definition for the blackbox
563

'test' is defined but never used

src/componentAPI.ts

 58import NormallyClosedValveCrescents from "./app/library/geometricElements/normallyClosedValveCrecents";
 59import NormallyClosedValveModificationsGap from "./app/library/geometricElements/normallyClosedValveGap";
 60import { ValveType } from "./app/core/init";
 61import { test } from "mocha"; 62
 63export var PRIMITIVES_SERVER = false;
 64

'event' is defined but never used

src/app/view/tools/generateArrayTool.ts

 31            // ref.dragging = true;
 32            // ref.showTarget();
 33        };
 34        this.move = function(event) { 35            // if (ref.dragging) {
 36            //     ref.lastPoint = MouseTool.getEventPosition(event);
 37            //     ref.updateQueue.run();

'SimpleQueue' is defined but never used

src/app/view/tools/generateArrayTool.ts

  1import MouseTool, { MouseToolCallback } from "./mouseTool";
  2
  3import Registry from "../../core/registry";
  4import SimpleQueue from "../../utils/simpleQueue";  5import Component from "@/app/core/component";
  6import ViewManager from "../viewManager";
  7

'MouseToolCallback' is defined but never used

src/app/view/tools/generateArrayTool.ts

  1import MouseTool, { MouseToolCallback } from "./mouseTool";  2
  3import Registry from "../../core/registry";
  4import SimpleQueue from "../../utils/simpleQueue";

'zfactor' is assigned a value but never used

src/app/view/render2D/paperComponentPortView.ts

20    }
21
22    addComponentPortElements(component: Component) {
23        const zfactor = 1;24        if (!this._componentAndRenderMap.has(component.id)) {
25            this._componentAndRenderMap.set(component.id, []);
26        }

'Point' is defined but never used

src/app/view/render2D/paperComponentPortView.ts

 1import Component from "@/app/core/component";
 2import { Point } from "paper/dist/paper-core"; 3import ViewManager from "../viewManager";
 4import ComponentPortRenderer2D from "./componentPortRenderer2D";
 5

'set' is assigned a value but never used

src/app/view/render2D/featureRenderer2D.ts

132    let set = "Basic";
133    if (ComponentAPI.isCustomType(type)) {
134        //(Eric) all blackbox code should be in here
135        set = "Custom";136        rendered = DXFSolidObjectRenderer2D.renderCustomComponentFeature(feature, getBaseColor(feature));
137        let modrendered = rendered as any;
138        modrendered["featureID"] = feature.ID;

'Registry' is defined but never used

src/app/view/render2D/componentPortRenderer2D.ts

 1import * as Colors from "../colors";
 2import paper from "paper";
 3import Registry from "../../core/registry"; 4import  Component  from "@/app/core/component";
 5import ComponentPort from "@/app/core/componentPort";
 6import { Point } from "@/app/core/init";

'physical' is defined but never used

src/app/view/paperView.ts

 792     * @param featureIDs [String] Feature id's of all the features that will be a part of this component
 793     * @param physical Boolean stating whether feature physical or not
 794     */
 795    addComponent(typeString: string, paramdata: { [index: string]: Parameter }, featureIDs: Array<string>, physical: boolean) { 796        if (Registry.viewManager === undefined || Registry.viewManager === null) {
 797            console.error("ViewManager is not defined");
 798            throw new Error("ViewManager is not defined");

'ComponentPortRenderer2D' is defined but never used

src/app/view/paperView.ts

  13import * as Colors from "./colors";
  14import ManufacturingLayer from "../manufacturing/manufacturingLayer";
  15import RatsNestRenderer2D from "./render2D/ratsNestRenderer2D";
  16import ComponentPortRenderer2D from "./render2D/componentPortRenderer2D";  17import PaperComponentPortView from "./render2D/paperComponentPortView";
  18import * as DXFObjectRenderer2D from "./render2D/dxfObjectRenderer2D";
  19import * as DXFSolidObjectRenderer from "./render2D/dxfSolidObjectRenderer2D";

'DeviceInterchangeV1_1' is defined but never used

src/app/utils/loadUtils.ts

 24    ComponentPortInterchangeV1,
 25    LogicalLayerType,
 26    ValveType,
 27    DeviceInterchangeV1_1 28} from "@/app/core/init";
 29
 30export default class LoadUtils {

'ValveType' is defined but never used

src/app/utils/loadUtils.ts

 23    ConnectionInterchangeV1_2,
 24    ComponentPortInterchangeV1,
 25    LogicalLayerType,
 26    ValveType, 27    DeviceInterchangeV1_1
 28} from "@/app/core/init";
 29

'CustomComponent' is defined but never used

src/app/utils/loadUtils.ts

  6import Params from "@/app/core/params";
  7import RenderLayer from "@/app/view/renderLayer";
  8
  9import CustomComponent from "@/app/core/customComponent"; 10import ComponentPort from "@/app/core/componentPort";
 11import { ComponentAPI } from "@/componentAPI";
 12import MapUtils from "./mapUtils";

'drawleafs' is assigned a value but never used

src/app/library/ytree.ts

227        }
228    }
229
230    __drawYtwig(treepath: paper.CompoundPath, px: number, py: number, cw: number, stagelength: number, spacing: number, drawleafs = false): paper.CompoundPath  {231        const pivotpoint = new paper.Point(px, py);
232
233        // stem

'l' is assigned a value but never used

src/app/library/ytree.ts

185            isodd = true;
186        }
187        const w = spacing * (leafs / 2 + 1);
188        const l = (levels + 1) * stagelength;189
190        const treepath = new paper.CompoundPath("");
191

'isodd' is assigned a value but never used

src/app/library/ytree.ts

182        if (leafs % 2 === 0) {
183            isodd = false;
184        } else {
185            isodd = true;186        }
187        const w = spacing * (leafs / 2 + 1);
188        const l = (levels + 1) * stagelength;

'rotation' is assigned a value but never used

src/app/library/ytree.ts

170            leafs = outs;
171        } else {
172            leafs = ins;
173            rotation += 180;174        }
175        const color = params.color;
176        const stagelength = params.stageLength;

'key' is defined but never used

src/app/library/ytree.ts

158        return ports;
159    }
160
161    render2D(params: { [k: string]: any }, key: string) {162        const position = params.position;
163        const cw = params.flowChannelWidth;
164        let rotation = params.rotation;

'rotation' is assigned a value but never used

src/app/library/ytree.ts

139            leafs = outs;
140        } else {
141            leafs = ins;
142            rotation += 180;143        }
144        const stagelength = params.stageLength;
145

'CompoundPath' is defined but never used

src/app/library/ytree.ts

  2import paper from "paper";
  3import ComponentPort from "../core/componentPort";
  4import { LogicalLayerType } from "../core/init";
  5import { CompoundPath } from "paper/dist/paper-core";  6
  7export default class YTree extends Template {
  8    constructor() {

'rotation' is assigned a value but never used

src/app/library/valve.ts

118        const l = params.length;
119        const w = params.width;
120        const color = params.color;
121        const rotation = params.rotation;122        const startX = px - w / 2;
123        const startY = py - l / 2;
124        const endX = px + w / 2;

'key' is assigned a value but never used

src/app/library/valve.ts

111        return ports;
112    }
113
114    render2D(params: { [k: string]: any }, key = "CONTROL") {115        const position = params.position;
116        const px = position[0];
117        const py = position[1];

Description

Unused variables are generally considered a code smell and should be avoided.

Removing unused references - It prevents unused modules from being loaded at runtime, improving performance, and preventing the compiler from loading metadata that will never be used. - It prevents conflicts that may occur when trying to reference another variable.

NOTE: If you have intentionally left a variable unused, we suggest you to prefix the variable name with a _ to prevent them from being flagged by DeepSource.

Bad Practice

import fs from 'fs' // <- unused
import { readFileSync } from 'fs'

const text = readFileSync('declaration_of_independence.txt', 'utf-8')
console.log(text)

CIDARLAB / 3DuF

Bad Practice

Recommended