Use
const declarations for variables that are never reassigned JS-0242
Anti-pattern
Minor
15 days ago
—
3 years old
'technology' is never reassigned. Use 'const' instead
62 console.log(req.query, req.query.mint, req.query["mint"]);
63 let primitive = req.query.mint;
64 let key = primitive as string;
65 let technology = ComponentAPI.getComponentWithMINT(key);66
67 if (technology === null) {
68 console.error("Could not find MINT:", key);'key' is never reassigned. Use 'const' instead
61const getDefaults = async (req: Request, res: Response, next: NextFunction) => {
62 console.log(req.query, req.query.mint, req.query["mint"]);
63 let primitive = req.query.mint;
64 let key = primitive as string;65 let technology = ComponentAPI.getComponentWithMINT(key);
66
67 if (technology === null) {'primitive' is never reassigned. Use 'const' instead
60
61const getDefaults = async (req: Request, res: Response, next: NextFunction) => {
62 console.log(req.query, req.query.mint, req.query["mint"]);
63 let primitive = req.query.mint;64 let key = primitive as string;
65 let technology = ComponentAPI.getComponentWithMINT(key);
66'port' is never reassigned. Use 'const' instead
49
50 let ret = [];
51 for (let i = 0; i < ports.length; i++) {
52 let port = ports[i];53 port.x = Math.floor(port.x + drawoffsets[0]);
54 port.y = Math.floor(port.y + drawoffsets[1]);
55 ret.push(port.toInterchangeV1());'ret' is never reassigned. Use 'const' instead
47 let ports = technology.getPorts(params);
48 const drawoffsets = technology.getDrawOffset(params);
49
50 let ret = [];51 for (let i = 0; i < ports.length; i++) {
52 let port = ports[i];
53 port.x = Math.floor(port.x + drawoffsets[0]);
Description
Variables that are never re-assigned a new value after their initial declaration should be declared with the const keyword.
This prevents the programmer from erroneously re-assigning to a read-only variable, and informs those reading the code that a variable is a constant value.
Bad Practice
let pi = Math.PI
for (let x of xs) {
use(x);
}
let { a, b } = object;
use(a, b);
Recommended
const pi = Math.PI
for (const x of xs) {
use(x);
}
const { a, b } = object;
use(a, b);