Class methods should utilize
this JS-0105
Anti-pattern
Minor
15 days ago
—
3 years old
Expected 'this' to be used by class method 'updatesConnectionRender'
1427 * @returns {void}
1428 * @memberof ViewManager
1429 */
1430 updatesConnectionRender(connection: Connection): void {1431 // First Redraw all the segements without valves or insertions
1432 connection.regenerateSegments();
1433Expected 'this' to be used by class method 'killParamsWindow'
1361 * @returns {void}
1362 * @memberof ViewManager
1363 */
1364 killParamsWindow(): void {1365 const paramsWindow = document.getElementById("parameter_menu");
1366 if (paramsWindow) paramsWindow.parentElement?.removeChild(paramsWindow);
1367 }Expected 'this' to be used by class method 'setupDragAndDropLoad'
1333 * @returns {void}
1334 * @memberof ViewManager
1335 */
1336 setupDragAndDropLoad(selector: string): void {1337 const dnd = HTMLUtils.DnDFileController(selector, function(files) {
1338 const f = files[0];
1339Expected 'this' to be used by class method 'revertFieldToDefault'
1165 * @returns {void}
1166 * @memberof ViewManager
1167 */
1168 revertFieldToDefault(valueString: string, feature: Feature): void {1169 feature.updateParameter(valueString, ComponentAPI.getDefaultsForType(feature.getType())[valueString]);
1170 }
1171Expected 'this' to be used by class method 'updateDefault'
1139 * @returns {void}
1140 * @memberof ViewManager
1141 */
1142 updateDefault(typeString: string, valueString: string, value: any): void {1143 // Registry.featureDefaults[setString][typeString][valueString] = value;
1144 const defaults = ComponentAPI.getDefaultsForType(typeString);
1145 defaults[valueString] = value;
Description
If a class method does not use this, it can sometimes be made into a static function. If you do convert the method into a static function, instances of the class that call that particular method have to be converted to a static call as well (MyClass.callStaticMethod())
Bad Practice
class Person {
sayHi() {
const greeting = document.createElement("div");
greeting.innerText = "Hello!";
document.appendChild();
}
}
const person = new Person();
person.sayHi();
Recommended
class Person {
static sayHi() {
const greeting = document.createElement("div");
greeting.innerText = "Hello!";
document.appendChild();
}
}
Person.sayHi();