Void operators found JS-0098
Anti-pattern
Minor
15 days ago
—
3 years old
Expected 'undefined' and instead saw 'void'
2038 }
2039 // Get the slider value.
2040 function valueGet(unencoded) {
2041 if (unencoded === void 0) { unencoded = false; }2042 if (unencoded) {
2043 // return a copy of the raw values
2044 return scope_Values.length === 1 ? scope_Values[0] : scope_Values.slice(0);Expected 'undefined' and instead saw 'void'
12 PipsMode["Count"] = "count";
13 PipsMode["Values"] = "values";
14 })(exports.PipsMode || (exports.PipsMode = {}));
15 exports.PipsType = void 0; 16 (function (PipsType) {
17 PipsType[PipsType["None"] = -1] = "None";
18 PipsType[PipsType["NoValue"] = 0] = "NoValue";Expected 'undefined' and instead saw 'void'
4 (global = typeof globalThis !== 'undefined' ? globalThis : global || self, factory(global.noUiSlider = {}));
5})(this, (function (exports) { 'use strict';
6
7 exports.PipsMode = void 0; 8 (function (PipsMode) {
9 PipsMode["Range"] = "range";
10 PipsMode["Steps"] = "steps";
Description
A return; statement with nothing after it is redundant, and has no effect on the runtime behavior of a function.
This can be confusing, so it's better to disallow these redundant statements.
Bad Practice
function foo() { return; }
function foo() {
doSomething();
return;
}
function foo() {
if (condition) {
bar();
return;
} else {
baz();
}
}
function foo() {
switch (bar) {
case 1:
doSomething();
default:
doSomethingElse();
return;
}
}
Recommended
function foo() { return 5; }
function foo() {
return doSomething();
}
function foo() {
if (condition) {
bar();
return;
} else {
baz();
}
qux();
}
function foo() {
switch (bar) {
case 1:
doSomething();
return;
default:
doSomethingElse();
}
}
function foo() {
for (const foo of bar) {
return;
}
}