JS-0096 · Unnecessary concatenation of literals or template literals found

CIDARLAB / 3DuF

Active

Unnecessary concatenation of literals or template literals found JS-0096

Anti-pattern

Minor

15 days ago — 3 years old

Unexpected string concatenation of literals

 99    A100: "#" + "ebffeb",
100    A200: "#" + "9dff9d",
101    A400: "#" + "14ff14",
102    A700: "#" + "00b100"103};
104
105const layerColors = {

Unexpected string concatenation of literals

src/app/view/colors.ts

 98    50: "#" + "b1ffb1",
 99    A100: "#" + "ebffeb",
100    A200: "#" + "9dff9d",
101    A400: "#" + "14ff14",102    A700: "#" + "00b100"
103};
104

Unexpected string concatenation of literals

src/app/view/colors.ts

 97    100: "#" + "62ff62",
 98    50: "#" + "b1ffb1",
 99    A100: "#" + "ebffeb",
100    A200: "#" + "9dff9d",101    A400: "#" + "14ff14",
102    A700: "#" + "00b100"
103};

Unexpected string concatenation of literals

src/app/view/colors.ts

 96    200: "#" + "3bff3b",
 97    100: "#" + "62ff62",
 98    50: "#" + "b1ffb1",
 99    A100: "#" + "ebffeb",100    A200: "#" + "9dff9d",
101    A400: "#" + "14ff14",
102    A700: "#" + "00b100"

Unexpected string concatenation of literals

src/app/view/colors.ts

 95    300: "#" + "00ff00",
 96    200: "#" + "3bff3b",
 97    100: "#" + "62ff62",
 98    50: "#" + "b1ffb1", 99    A100: "#" + "ebffeb",
100    A200: "#" + "9dff9d",
101    A400: "#" + "14ff14",

Description

It's unnecessary to concatenate two string literals together, such as:

let foo = "a" + "b";

This code is likely the result of refactoring where a variable was removed from the concatenation (such as "a" + b + "b"). In such a case, the concatenation isn't important and the code can be rewritten as:

let foo = "ab";

Bad Practice

let a = `some` + `string`;

// these are the same as "10"
a = '1' + '0';
a = '1' + `0`;
a = `1` + '0';
a = `1` + `0`;

CIDARLAB / 3DuF

Bad Practice

Recommended