PYL-W0614 @ dad8705 • Bulkmailer / BulkMailer-Backend

Run summary

a year ago

3f113e1..dad8705

49 s

Unused import from wildcard import found PYL-W0614

Anti-pattern

Major

8 occurrences in this check

Unused import(s) random, send_otp, send_custom_mass_mail, status_update, shared_task, settings, EmailMultiAlternatives, get_connection, Context, Template, timezone, TaskResult, GroupResource, models, resources, Field, ForeignKeyWidget, MyUserManager, NewUserRegistration, GmailAPPModel, OTP, revoke_tokens, AbstractBaseUser, BaseUserManager, EmailValidator, pre_save, receiver, BlacklistedToken, OutstandingToken and RefreshToken from wildcard import of authentication.task

mailer/views.py

  3from rest_framework.permissions import IsAuthenticated
  4from rest_framework.response import Response
  5
  6from authentication.task import *  7from bulkmailer.celery import app
  8from mailer.serializers import *
  9

Unused import(s) request, generics, status, IsAuthenticated, Response, random, re, send_otp, send_custom_mass_mail, status_update, shared_task, settings, EmailMultiAlternatives, get_connection, Context, Template, timezone, TaskResult, Groups, GroupDetails, GroupResource, TemplateModel, SentMail, FileUploadForMail, models, resources, Field, ForeignKeyWidget, MyUserManager, NewUserRegistration, GmailAPPModel, OTP, revoke_tokens, AbstractBaseUser, BaseUserManager, EmailValidator, pre_save, receiver, BlacklistedToken, OutstandingToken, RefreshToken, app, pytz, CreateGroupSerializer, ViewGroupDataSerializer, AddContactsManuallySerializer, MassMailSerializer, FileUploadSerializer, TemplateSerializer, fields, datetime, BeautifulSoup, ValidationError and serializers from wildcard import of views

mailer/urls.py

 1from django.urls import path
 2
 3from .views import * 4
 5urlpatterns = [
 6    path("create_group/", CreateGroup.as_view()),

Unused import(s) random, re, send_otp, status_update, shared_task, settings, EmailMultiAlternatives, get_connection, Context, Template, timezone, TaskResult, GroupResource, models, resources, Field, ForeignKeyWidget, MyUserManager, NewUserRegistration, GmailAPPModel, OTP, revoke_tokens, AbstractBaseUser, BaseUserManager, EmailValidator, pre_save, receiver, BlacklistedToken, OutstandingToken and RefreshToken from wildcard import of authentication.task

mailer/serializers.py

  6from django.core.exceptions import ValidationError
  7from rest_framework import serializers
  8
  9from authentication.task import * 10from bulkmailer.celery import app
 11
 12from .models import *

Unused import(s) MyUserManager, GmailAPPModel, OTP, revoke_tokens, AbstractBaseUser, BaseUserManager, EmailValidator, pre_save, receiver, timezone, BlacklistedToken, OutstandingToken and RefreshToken from wildcard import of authentication.models

mailer/models.py

 3from import_export.fields import Field
 4from import_export.widgets import ForeignKeyWidget
 5
 6from authentication.models import * 7
 8
 9# Create your models here.

Unused import(s) email, re, timedelta, authenticate, make_password, ValidationError, serializers, random, send_otp, send_custom_mass_mail, status_update, shared_task, settings, EmailMultiAlternatives, get_connection, Context, Template, TaskResult, Groups, GroupDetails, GroupResource, TemplateModel, SentMail, FileUploadForMail, resources, Field and ForeignKeyWidget from wildcard import of serializers

authentication/views.py

  3from rest_framework.response import Response
  4
  5from .models import *
  6from .serializers import *  7
  8
  9# API for sending OTP.

Unused import(s) generics, mixins, status, IsAuthenticated, Response, MyUserManager, GmailAPPModel, OTP, revoke_tokens, AbstractBaseUser, BaseUserManager, EmailValidator, models, pre_save, receiver, timezone, BlacklistedToken, OutstandingToken, RefreshToken, email, re, OTPSerializer, OTPVerifySerializer, NewUserSerializer, LoginSerializer, ChangePasswordSerializer, ResetPasswordViewOTPSerializer, GmailAPPModelSerializer, UpdateAppPassword, ProfileDetailsUpdateSerializer, timedelta, authenticate, make_password, ValidationError, serializers, random, send_otp, send_custom_mass_mail, status_update, shared_task, settings, EmailMultiAlternatives, get_connection, Context, Template, TaskResult, Groups, GroupDetails, GroupResource, TemplateModel, SentMail, FileUploadForMail, resources, Field and ForeignKeyWidget from wildcard import of views

authentication/urls.py

 1from django.urls import path
 2from rest_framework_simplejwt.views import TokenRefreshView
 3
 4from .views import * 5
 6urlpatterns = [
 7    path("token/", TokenRefreshView.as_view()),

Unused import(s) Groups, GroupResource, models, resources, Field, ForeignKeyWidget, MyUserManager, NewUserRegistration, revoke_tokens, AbstractBaseUser, BaseUserManager, EmailValidator, pre_save, receiver, BlacklistedToken, OutstandingToken and RefreshToken from wildcard import of mailer.models

authentication/task.py

 9from django.utils import timezone
10from django_celery_results.models import TaskResult
11
12from mailer.models import *13from mailer.models import GroupDetails
14
15from .models import *

Unused import(s) random, send_custom_mass_mail, status_update, shared_task, settings, EmailMultiAlternatives, get_connection, Context, Template, TaskResult, Groups, GroupDetails, GroupResource, TemplateModel, SentMail, FileUploadForMail, resources, Field and ForeignKeyWidget from wildcard import of task

authentication/serializers.py

  8from rest_framework import serializers
  9
 10from .models import *
 11from .task import * 12
 13
 14class OTPSerializer(serializers.ModelSerializer):

Description

In a wildcard import, all public names defined in the module are imported. It is advised to explicitly import the values needed or modify the module being imported from and define all to restrict the names to be imported.