Inconsistency of Printf format strings and arguments VET-V0013
Bug risk
Major
2 years ago
—
2 years old
fmt.Sprintf format %d has arg enabledFactor of wrong type string
148
149 enabledFactorsMap := make(map[string]interface{})
150 for _, enabledFactor := range user.EnabledMFAs {
151 if mfa, ok := secondFactors[fmt.Sprintf("%d", enabledFactor)]; ok {152 path := fmt.Sprintf("%s/mfa/%s", app.url.String(), strings.ReplaceAll(mfa.GetMetadata().ShortName, "_", "-"))
153 enabledFactorsMap[mfa.GetMetadata().ShortName] = path
154 }
Description
Inconsistent types between the format specifiers in a string and the arguments passed to it may result in weird results.
Bad practice
s := "hello"
x := fmt.Sprintf("%d", s) // will print `%!d(string=hello)`
Recommended
s := "hello"
x := fmt.Sprintf("%s", s) // will print `hello`