Ruby

Ruby

By DeepSource

Undefined attribute for ActiveRecord model RB-E1006
Bug risk

Rails' ActiveRecord ORM allows you to search a model using its attributes, however if you provide an attribute that doesn't exist on a model, it will throw an ActiveRecord::StatementInvalid error.

Method not defined on controller RB-E1007
Bug risk

Rails expects the route to match an existing action (method) in the specified controller. If the method doesn't exist, Rails won't be able to execute it and will raise an error. This is to ensure that you have defined all the necessary actions in your controller and that your routes accurately reflect the available actions.

Invalid association in ActiveRecord Model RB-E1008
Bug risk

If you add an association to an ActiveRecord model that doesn't define a reference in the migration, you may encounter errors when trying to perform certain operations on the model or when accessing associated data.

IO.select with single argument detected RB-DS1003
Bug risk

IO.select statements can get very hard to make them compatible with Ruby 3 scheduler. It is recommended to use wait_readable or wait_writable on an IO object with a given timeout instead of rescuing an IO::WaitReadable or IO::WaitWritable error and using IO.select in the block.

Unused method arguments detected RB-LI1074
Bug risk

If an unused method argument is intended, it should be prefixed with an underscore.

Duplicate value detected in enum declarations RB-RL1019
Bug risk

Safe navigation used with blank? RB-RL1050
Bug risk

While the safe navigation operator is generally a good idea, when checking foo&.blank? in a conditional, foo being nil will actually do the opposite of what was intended.

Bad ordering of magic comments RB-LI1042
Bug risk

Duplicate require/require_relative blocks were found RB-LI1096
Bug risk

Requiring, or relatively requiring same file/module twice is unnecessary and either of the blocks can be removed as they both serve the same purpose.

Unexpected override of built-in Struct method RB-W1007
Bug risk

When creating a custom value object using Struct.new, be careful as to not have attributes whose names match the built-in methods provided by the Struct class.

Arguments to range literal are ambiguous RB-W1006
Bug risk

Range literal should be enclosed in parentheses when the end of the range is at a line break, otherwise the intention of the code becomes ambigous.

return detected inside ensure RB-LI1021
Bug risk

Do not return from an ensure block. If you explicitly return from a method inside an ensure block, the return will take precedence over any exception being raised, and the method will return as if no exception had been raised

Exception class overwritten by its result RB-E1001
Bug risk
Autofix

You intended to write as rescue StandardError. However, you have written rescue => StandardError. In that case, the result of rescue will overwrite StandardError.

Lambda without a literal block is deprecated RB-W1004
Bug risk
Autofix

Lambda without a literal block is deprecated since Ruby 3.0, use the proc without lambda instead.

Risk of race condition in non-atomic file operation RB-E1002
Bug risk

Non-atomic file operations can cause problems that are difficult to reproduce, especially in cases of frequent file operations in parallel, such as test runs with parallel_rspec.

uniqueness: true used on a field that is not an index RB-W1022
Bug risk

Defining uniqueness: true on an ActiveRecord model can be error prone if the column hasn't been declared unique at the database level.

Deprecated method used inside refine block RB-W1005
Bug risk

Starting from Ruby 3.1, include or prepend must not be used within a refine block. These methods are deprecated and should be replaced with Refinement#import_methods.

Duplicate magic comment found RB-W1008
Bug risk
Autofix

Having duplicate magic comments can lead to potential bug-risks, as a duplicate magic comment can have a different argument passed to it which can change the behavior of the program or even cause it to crash.

Usage of "*" on Arel::Table column reference RB-W1018
Bug risk

Avoid using "*" on an Arel::Table column reference.

Usage of Time.zone= method RB-W1019
Bug risk

Setting the timezone using Time.zone= should be avoided.