JavaScript

JavaScript

Made by DeepSource

Should not use needs to load other controllers JS-0770

Bug risk
Minor
ember

Avoid using needs to load other controllers. Inject the required controller instead. needs was deprecated in ember 1.x and removed in 2.0.

Bad Practice

export default Controller.extend({
  needs: ['comments'],
  newComments: alias('controllers.comments.newest')
});

Recommended

import Controller, { inject as controller } from '@ember/controller';

export default Component.extend({
  comments: controller(),
  newComments: alias('comments.newest')
});