Loops must terminate by some means JAVA-S0024

This loop doesn't seem to have a way to terminate (other than by perhaps throwing an exception).

It is better to explicitly break out of the loop instead of relying on a possibly unclear exit condition.

Examples

Bad Practice

while(true) {

    doSomething(...);

    // ...
}

It is inadvisable to break out of an infinite loop using an exception if that is what is intended; control flow expressions such as break and return exist for this purpose.

Recommended

while(true) {

    doSomething(...);

    if (somethingElse) break;
}

If this loop is not intentional, it may cause the application to hang unexpectedly.

References

• CERT MSC01-J - Do not use an empty infinite loop.
• Spotbugs - IL_INFINITE_LOOP