Close instances of dart.core.Sink DRT-W1011
Bug risk
Major
DO invoke close on instances of dart.core.Sink.
Closing instances of Sink prevents memory leaks and unexpected behavior.
BAD:
class A {
IOSink _sinkA;
void init(filename) {
_sinkA = File(filename).openWrite(); // LINT
}
}
BAD:
void someFunction() {
IOSink _sinkF; // LINT
}
GOOD:
class B {
IOSink _sinkB;
void init(filename) {
_sinkB = File(filename).openWrite(); // OK
}
void dispose(filename) {
_sinkB.close();
}
}
GOOD:
void someFunctionOK() {
IOSink _sinkFOK; // OK
_sinkFOK.close();
}
Known limitations
This rule does not track all patterns of Sink instantiations and closures. See linter#1381 for more information.