Found empty block statements JS-0009
Anti-pattern
8 months ago
—
8 months old
Empty block statement.
11796 c = !0;
11797 try {
11798 (window.event.cancelBubble = !0), event.stopPropagation();
11799 } catch (e) {}11800 "object" != typeof s && (s = {});
11801 var r = i.getAttribute("aria-controls"),
11802 f = document.getElementById(r),Empty block statement.
11589 (o.Close = function (o, a) {
11590 try {
11591 (window.event.cancelBubble = !0), event.stopPropagation();
11592 } catch (e) {}11593 void 0 === o.length && (o = [o]);
11594 for (var i = 0; i < o.length; i++) {
11595 var l = o[i],Empty block statement.
11557 (o.Open = function (o, a) {
11558 try {
11559 (window.event.cancelBubble = !0), event.stopPropagation();
11560 } catch (e) {}11561 void 0 === o.length && (o = [o]);
11562 for (var i = 0; i < o.length; i++) {
11563 var l = o[i],Empty block statement.
11515 (o.Toggle = function (o, a, i) {
11516 try {
11517 (window.event.cancelBubble = !0), event.stopPropagation();
11518 } catch (e) {}11519 void 0 === o.length && (o = [o]), "object" != typeof i && (i = {});
11520 for (var l = 0; l < o.length; l++) {
11521 var c = o[l],Empty block statement.
10785 try {
10786 m.contentWindow.document.execCommand &&
10787 m.contentWindow.document.execCommand("Stop");
10788 } catch (e) {}10789 d.attr("src", l.iframeSrc),
10790 (p.error = t),
10791 l.error && l.error.call(l.context, p, t, e),
Description
Empty block statements, while not technically errors, usually occur due to refactoring that wasn't completed. They can mislead the reader.
If you still want to keep an empty block, add a comment saying empty inside the block.
Bad Practice
if (someCheck) {}
while (someCheck) {}
try {
doSomething();
} catch(err) {
} finally {
}
Recommended
if (someCheck) {
// empty
}
while (someCheck) {
/* empty */
}
try {
doSomething();
} catch (err) {
// continue regardless of error
}
try {
doSomething();
} finally {
/* continue regardless of error */
}