Found shorthand type coercions JS-0066
Anti-pattern
Minor
2 hours ago
—
a year old
use
Boolean(attrCat) instead169
170 const inputContainerWithSkeleton = useCallback(
171 (children: ReactNode) => (
172 <Skeleton visible={!!attrCat && attributesByCategoryApi.isLoading} radius='md'>173 {children}
174 </Skeleton>
175 ),use
Boolean(orgId) instead 65 const { data: initialData, isFetching } = api.orgPhone.forEditDrawer.useQuery(
66 { id: phoneId },
67 {
68 enabled: !!orgId || !createNew, 69 }
70 )
71 const { data: phoneTypes } = api.fieldOpt.phoneTypes.useQuery(undefined, {use
Boolean(data) instead18 'LuxonInterval'
19)
20export const isSuperJSONResult = (data: unknown): data is SuperJSONResult =>
21 !!data && typeof data === 'object' && !Array.isArray(data) && 'json' in data22
23export { type SuperJSONResult }
24export const transformer = superjsonuse
Boolean(process.env.PRISMA_VERBOSE) instead 2import { type ISettingsParam, Logger } from 'tslog'
3
4const isDev = process.env.NODE_ENV === 'development'
5const verboseLogging = Boolean(isDev && (!!process.env.NEXT_VERBOSE || !!process.env.PRISMA_VERBOSE)) 6export const appLog = new Logger({
7 name: 'app',
8 type: isDev ? 'pretty' : 'json',use
Boolean(process.env.NEXT_VERBOSE) instead 2import { type ISettingsParam, Logger } from 'tslog'
3
4const isDev = process.env.NODE_ENV === 'development'
5const verboseLogging = Boolean(isDev && (!!process.env.NEXT_VERBOSE || !!process.env.PRISMA_VERBOSE)) 6export const appLog = new Logger({
7 name: 'app',
8 type: isDev ? 'pretty' : 'json',
Description
Prefer using explicit casts by calling Number, Boolean, or String over using operators like +, !! or "" +.
This is considered best practice as it improves readability.
Bad Practice
const b = !!foo;
// The `+` operator does not change the value of its operand
// unless it's already a number.
let n = +foo;
n = 1 * foo;
const s = "" + foo;
Recommended
const b = Boolean(foo);
const n = Number(foo);
const s = String(foo);