Should not have unused variables JS-0128
Bug risk
2 months ago
—
8 months old
'collapseEl' is assigned a value but never used. Allowed unused vars must match /^_/u
6
7 if (sidebar) {
8
9 let collapseEl = sidebar.querySelector('.collapse');10 let collapseElementList = [].slice.call(document.querySelectorAll('.sidebar .collapse'))
11 let sidebarCollapseList = collapseElementList.map(function (collapseEl) {
12 return new bootstrap.Collapse(collapseEl, { toggle: false });'e' is defined but never used. Allowed unused args must match /^_/u
15 for (let toggle of sidebarToggles) {
16
17 // Toggle the side navigation
18 toggle.addEventListener('click', function(e) {19 document.body.classList.toggle('sidebar-toggled');
20 sidebar.classList.toggle('toggled');
21'selectClient' is defined but never used. Allowed unused vars must match /^_/u
28 * @param id - the id of the client
29 * @param name - The name of the input field
30 */
31function selectClient(id, name) {32 document.getElementById('client_id').value = id;
33 document.getElementById('client').value = name;
34 $('.modal').modal('hide'); 'selectCity' is defined but never used. Allowed unused vars must match /^_/u
17/*
18 * @param city_id - The id of the city you want to select
19 */
20function selectCity(city_id) {21 let url = "/city/" + city_id;
22 $.get(url, function(data){
23 $("#city_id").empty();'data' is defined but never used. Allowed unused args must match /^_/u
46 data: {
47 _token: csrf
48 },
49 success: function(data) {50 alert('Usuario removido com sucesso');
51 }
52 });
Description
Found variables that are declared but not used anywhere.
NOTE: In browser applications, DeepSource recommends the use of ESModules over regular
text/javascriptscripts. Currently, we don't support variables that are not explicitly exported, and are injected into other scripts by being included in an HTML file
Unused variables are most often the result of incomplete refactoring. They can lead to confusing code and minor performance hitches.
NOTE: If you have intentionally left a variable unused, we suggest you to prefix the variable name with a _ to prevent them from being flagged by DeepSource.
Bad Practice
// Write-only variables are not considered as used.
let y = 10;
y = 5;
// A variable that modifies only itself isn't considered used.
let z = 0;
z = z + 1;
// Unused argument
(function(x) {
return 5;
})();
// Unused recursive functions also raise this issue.
function fact(n) {
if (n < 2) return 1;
return n * fact(n - 1);
}
// When a function definition destructures an array,
// unused entries from the array also cause warnings.
function getY([x, y]) {
return y;
}
Recommended
let x = 10;
alert(x);
((arg1) => {
return arg1;
})();
let myFunc;
myFunc = (n) => {
// this is legal
if (n < 0) myFunc();
};
// this is also considered legal
console.log(declaredLater);
var declaredLater;
// Only the second argument from the descructured array is used.
function getY([, y]) {
return y;
}