Simplify slice expression to sliced value itself CRT-A0016
Anti-pattern
Major
4 years ago
—
4 years old
could simplify hosts[
56 hosts[i], _ = netselect.NewHost(h, h)
57 }
58
59 selector, err := netselect.NewNetSelector(hosts[:]) 60 if err != nil {
61 fmt.Println("Error ", err)
62 return err
Description
If a value is of type slice already, it need not be converted to slice again.
Bad practice
f(s[:]) // s is string
copy(b[:], values...) // b is []byte
Recommended
f(s)
copy(b, values...)