Unused parameter in function RVV-B0012
Bug risk
Minor
21 days ago
—
2 years old
parameter 'limit' seems to be unused, consider removing or renaming it as _
10 "go.uber.org/zap"
11)
12
13func (c *VictoriaMetricsGroup) doTagQuery(ctx context.Context, isTagName bool, query string, limit int64, supportedFeatures *vmSupportedFeatures) ([]string, merry.Error) {14 logger := c.logger
15 var rewrite *url.URL
16 if isTagName {parameter 'limit' seems to be unused, consider removing or renaming it as _
229 return nil, nil, types.ErrNotImplementedYet
230}
231
232func (c *ClientProtoV3Group) doTagQuery(ctx context.Context, isTagName bool, query string, limit int64) ([]string, merry.Error) {233 logger := c.logger
234 var rewrite *url.URL
235 if isTagName {parameter 'ctx' seems to be unused, consider removing or renaming it as _
225func (c *ClientProtoV3Group) List(ctx context.Context) (*protov3.ListMetricsResponse, *types.Stats, merry.Error) {
226 return nil, nil, types.ErrNotImplementedYet
227}
228func (c *ClientProtoV3Group) Stats(ctx context.Context) (*protov3.MetricDetailsResponse, *types.Stats, merry.Error) {229 return nil, nil, types.ErrNotImplementedYet
230}
231parameter 'ctx' seems to be unused, consider removing or renaming it as _
222 return r, stats, nil
223}
224
225func (c *ClientProtoV3Group) List(ctx context.Context) (*protov3.ListMetricsResponse, *types.Stats, merry.Error) {226 return nil, nil, types.ErrNotImplementedYet
227}
228func (c *ClientProtoV3Group) Stats(ctx context.Context) (*protov3.MetricDetailsResponse, *types.Stats, merry.Error) {parameter 'tldCacheDisabled' seems to be unused, consider removing or renaming it as _
64 return NewWithLimiter(logger, config, tldCacheDisabled, l)
65}
66
67func NewWithLimiter(logger *zap.Logger, config types.BackendV2, tldCacheDisabled bool, l limiter.ServerLimiter) (types.BackendServer, merry.Error) { 68 logger = logger.With(zap.String("type", "protoV3Group"), zap.String("name", config.GroupName))
69
70 httpClient := helper.GetHTTPClient(logger, config)
Description
Unused parameters in functions or methods should be replaced with _
(underscore) or removed.
Functions or methods with unused parameters can be a symptom of unfinished
refactoring or a bug. If an unused parameter is present, it should be named _
(underscore) to avoid raising this issue and better readability.
Bad practice
func abc(unused string) {
fmt.Println("Not using any passed params.")
}
Recommended
func abc(_ string) {
fmt.Println("Not using any passed params.")
}
func abc() {
fmt.Println("Not using any passed params.")
}