Unused method receiver RVV-B0013
Bug risk
3 months ago
—
3 months old
Method receiver 'l' is not referenced in method's body, consider removing it
21 return l
22}
23
24func (l *lys) Network() string {25 return "hijack"
26}
27Method receiver 'l' is not referenced in method's body, consider removing it
13 return <-l.Conns, nil
14}
15
16func (l *lys) Close() error {17 return nil
18}
19Method receiver 'f' is not referenced in method's body, consider removing it
25 return tty.New(c)
26}
27
28func (f *factory) MakeTtyEnv(c []string, env map[string]string) (agent.Tty, error) {29 return tty.NewEnv(c, env)
30}Method receiver 'f' is not referenced in method's body, consider removing it
21 return tty.New(f.args)
22}
23
24func (f *factory) MakeTtyCmd(c []string) (agent.Tty, error) {25 return tty.New(c)
26}
27
Description
Methods with unused receivers can be a symptom of unfinished refactoring or a bug. To keep the same method signature, omit the receiver name or '_' as it is unused.
Bad practice
func (f *Unix) Name() string {
return "unix"
}
func (_ *Unix) Name() string {
return "unix"
}
Recommended
func (*Unix) Name() string {
return "unix"
}