Use
const declarations for variables that are never reassigned JS-0242
Anti-pattern
Minor
3 months ago
—
2 years old
'result' is never reassigned. Use 'const' instead
700 body !== issue.body ||
701 state !== issue.state) {
702
703 let result = await octokit.rest.issues.update({704 owner,
705 repo,
706 issue_number,'state' is never reassigned. Use 'const' instead
690 let body = converter.makeMarkdown(wiObj.fields["System.Description"]).replace(/<br>/g, "").trim();
691
692 let states = config.ado.states;
693 let state = Object.keys(states).find(k => states[k]===wiObj.fields["System.State"]);694
695 log.debug(`[WORKITEM: ${workItem.id} / ISSUE: ${issue_number}] Title:`, title);
696 log.debug(`[WORKITEM: ${workItem.id} / ISSUE: ${issue_number}] Body:`, body);'states' is never reassigned. Use 'const' instead
689 let title = parsed.groups.title;
690 let body = converter.makeMarkdown(wiObj.fields["System.Description"]).replace(/<br>/g, "").trim();
691
692 let states = config.ado.states;693 let state = Object.keys(states).find(k => states[k]===wiObj.fields["System.State"]);
694
695 log.debug(`[WORKITEM: ${workItem.id} / ISSUE: ${issue_number}] Title:`, title);'body' is never reassigned. Use 'const' instead
687 if (new Date(wiObj.fields["System.ChangedDate"]) > new Date(issue.updated_at)) {
688 log.debug(`[WORKITEM: ${workItem.id} / ISSUE: ${issue_number}] WorkItem.ChangedDate (${new Date(wiObj.fields["System.ChangedDate"])}) is more recent than Issue.UpdatedAt (${new Date(issue.updated_at)}). Updating issue...`);
689 let title = parsed.groups.title;
690 let body = converter.makeMarkdown(wiObj.fields["System.Description"]).replace(/<br>/g, "").trim();691
692 let states = config.ado.states;
693 let state = Object.keys(states).find(k => states[k]===wiObj.fields["System.State"]);'title' is never reassigned. Use 'const' instead
686 // Can later add check to see if last entry in history of WorkItem was indeed updated by GitHub
687 if (new Date(wiObj.fields["System.ChangedDate"]) > new Date(issue.updated_at)) {
688 log.debug(`[WORKITEM: ${workItem.id} / ISSUE: ${issue_number}] WorkItem.ChangedDate (${new Date(wiObj.fields["System.ChangedDate"])}) is more recent than Issue.UpdatedAt (${new Date(issue.updated_at)}). Updating issue...`);
689 let title = parsed.groups.title;690 let body = converter.makeMarkdown(wiObj.fields["System.Description"]).replace(/<br>/g, "").trim();
691
692 let states = config.ado.states;
Description
Variables that are never re-assigned a new value after their initial declaration should be declared with the const keyword.
This prevents the programmer from erroneously re-assigning to a read-only variable, and informs those reading the code that a variable is a constant value.
Bad Practice
let pi = Math.PI
for (let x of xs) {
use(x);
}
let { a, b } = object;
use(a, b);
Recommended
const pi = Math.PI
for (const x of xs) {
use(x);
}
const { a, b } = object;
use(a, b);