Exception caught is very general PYL-W0703
Anti-pattern
Major
2 years ago
—
2 years old
Catching too general exception Exception
45def assign_matches_this_week():
46 try:
47 return assign()
48 except Exception as e:49 print(e)
50 rollbar.report_message("assign_matches_this_week failed")
51 return FalseCatching too general exception Exception
23 for scheduleinfo in schedules:
24 try:
25 schedule(**scheduleinfo)
26 except Exception as e:27 print(e)
Description
If the except block catches a very general exception, it is likely to catch any unrelated errors too. Try to be more explicit about which exception(s) you're trying to catch.
If you need to catch every other exception, then mark it as intentional by
adding a # skipcq comment.
Bad practice
try:
x = a / b
except Exception:
x = a / (b + 1)
try:
line = input('Enter numbers:')
numbers = [int(i) for i in line.split()]
except BaseException:
print('Only use numbers for the input')
Preferred:
try:
x = a / b
except ZeroDivisionError:
x = a / (b + 1)
try:
event_loop.run()
except Exception as exc: # skipcq: PYL-W0703 - Loop can sometimes crash.
sentry.report(exc)
try:
line = input('Enter numbers:')
numbers = [int(i) for i in line.split()]
except ValueError:
print('Only use numbers for the input')