Found empty functions JS-0057
Anti-pattern
Minor
a year ago
—
a year old
Unexpected empty arrow function.
28const app = express();
29app.use(cors<Request>(corsOptions));
30
31const server = app.listen(process.env.PORT || 9000, () => {}); // defined as 443 in the .env file32
33const peerServer = ExpressPeerServer(server, {
34 path: '/',
Description
Having empty functions hurts readability, and is considered a code-smell. There's almost always a way to avoid using them. If you must use one, consider adding a comment to inform the reader of its purpose.
Bad Practice
getUser('SwaGaLisTiQuE', () => {})
function f() {}
Recommended
getUser('SwaGaLisTiQuE', () => {
// empty because <reason>
})
function f() {
// intentionally empty. <reason>
}